Skip to content

feat: hide datasource legacy based on featureflag#11371

Merged
hughhhh merged 8 commits intomasterfrom
hugh/so-1114
Oct 27, 2020
Merged

feat: hide datasource legacy based on featureflag#11371
hughhhh merged 8 commits intomasterfrom
hugh/so-1114

Conversation

@hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 21, 2020 •
edited
Loading

SUMMARY

Hiding legacy datasource view based upon react_crud_views flag

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Flag: False

Screen Shot 2020-10-22 at 8 18 34 PM

Flag: True

Screen Shot 2020-10-22 at 8 20 17 PM

TEST PLAN

  1. Goto superset/config.py file
  2. Change ENABLE_REACT_CRUD_VIEWS to false
  3. Check if use Use Legacy Datasource Editor btn is hidden in DatasourceModal view

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot previously requested changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your PR title to match: ^(build|chore|ci|docs|feat|fix|perf|refactor|style|test|other)((.+))?:\s.+!

@hughhhh hughhhh changed the title hide datasource legacy based on featureflag feat: hide datasource legacy based on featureflag Oct 21, 2020
@github-actions github-actions bot dismissed their stale review October 21, 2020 20:53

All good!

@codecov-io
Copy link

codecov-io commented Oct 22, 2020 •
edited
Loading

Codecov Report

Merging #11371 into master will increase coverage by 0.39%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11371      +/-   ##
==========================================
+ Coverage   66.12%   66.52%   +0.39%     
==========================================
  Files         841      859      +18     
  Lines       40156    40965     +809     
  Branches     3685     3687       +2     
==========================================
+ Hits        26554    27252     +698     
- Misses      13501    13612     +111     
  Partials      101      101
Flag Coverage Δ
#cypress 56.30% <50.00%> (-0.02%) ⬇️
#javascript 62.95% <57.14%> (-0.01%) ⬇️
#python 62.02% <100.00%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/datasource/DatasourceModal.tsx 92.72% <66.66%> (-3.28%) ⬇️
superset-frontend/src/featureFlags.ts 100.00% <100.00%> (ø)
superset/config.py 90.18% <100.00%> (ø)
superset/models/annotations.py 89.65% <0.00%> (-2.94%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 92.06% <0.00%> (-1.59%) ⬇️
...t/annotation_layers/annotations/commands/delete.py 85.18% <0.00%> (ø)
superset/annotation_layers/commands/bulk_delete.py 85.71% <0.00%> (ø)
superset/annotation_layers/filters.py 92.85% <0.00%> (ø)
superset/annotation_layers/annotations/filters.py 92.85% <0.00%> (ø)
superset/annotation_layers/annotations/schemas.py 87.09% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81204a...26b6b35. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 23, 2020
@hughhhh hughhhh requested a review from betodealmeida October 23, 2020 03:24
@hughhhh hughhhh marked this pull request as ready for review October 26, 2020 13:09
@willbarrett willbarrett requested a review from nytai October 26, 2020 21:38
@willbarrett
Copy link
Member

willbarrett commented Oct 26, 2020

@lilykuang would you mind giving this a look?

nytai
nytai approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm curious what's the motivation for this? Is the idea to fully deprecate the old datasource editor. We have been getting quite a few bug reports on the new datasource editor, are we certain the new datasource editor is at 100% feature parity?

@willbarrett
Copy link
Member

willbarrett commented Oct 26, 2020

LGTM once green

@nytai
Copy link
Member

nytai commented Oct 26, 2020

retriggering CI, since #11433 merged

@nytai nytai closed this Oct 26, 2020
@nytai nytai reopened this Oct 26, 2020
@hughhhh hughhhh merged commit 81f77fd into master Oct 27, 2020
@hughhhh hughhhh deleted the hugh/so-1114 branch October 27, 2020 00:31
@john-bodley john-bodley mentioned this pull request Oct 29, 2020
Merged
6 tasks
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@hughhhh @auxten
feat: hide datasource legacy based on featureflag (apache#11371)
a78a03e
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilykuang lilykuang lilykuang approved these changes

@nytai nytai nytai approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0 First shipped in 1.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hughhhh @codecov-io @willbarrett @nytai @lilykuang @mistercrunch